linux-kernel - RE: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2023 09:36:00 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Sean Anderson <sean.anderson@...o.com>,
        Leo Li <leoyang.li@....com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     Scott Wood <oss@...error.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Roy Pledge <roy.pledge@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Sean Anderson <sean.anderson@...o.com>
Subject: RE: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...o.com>
> Sent: Friday, March 31, 2023 18:14
> To: Leo Li <leoyang.li@....com>; linuxppc-dev@...ts.ozlabs.org; linux-arm-
> kernel@...ts.infradead.org
> Cc: Scott Wood <oss@...error.net>; Camelia Alexandra Groza
> <camelia.groza@....com>; linux-kernel@...r.kernel.org; Roy Pledge
> <roy.pledge@....com>; David S . Miller <davem@...emloft.net>; Claudiu
> Manoil <claudiu.manoil@....com>; Vladimir Oltean
> <vladimir.oltean@....com>; Sean Anderson <sean.anderson@...o.com>
> Subject: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
> 
> cgr_lock may be locked with interrupts already disabled by
> smp_call_function_single. As such, we must use a raw spinlock to avoid
> problems on PREEMPT_RT kernels. Although this bug has existed for a
> while, it was not apparent until commit ef2a8d5478b9 ("net: dpaa: Adjust
> queue depth on rate change") which invokes smp_call_function_single via
> qman_update_cgr_safe every time a link goes up or down.
> 
> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
> Reported-by: Vladimir Oltean <vladimir.oltean@....com>
> Link: https://lore.kernel.org/all/20230323153935.nofnjucqjqnz34ej@skbuf/
> Signed-off-by: Sean Anderson <sean.anderson@...o.com>

Reviewed-by: Camelia Groza <camelia.groza@....com>