linux-kernel - RE: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB58074082181816E1AE71E87AF2939@VI1PR04MB5807.eurprd04.prod.outlook.com>
Date:   Tue, 4 Apr 2023 09:32:51 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Sean Anderson <sean.anderson@...o.com>,
        Vladimir Oltean <vladimir.oltean@....com>
CC:     Leo Li <leoyang.li@....com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Scott Wood <oss@...error.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Roy Pledge <roy.pledge@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: RE: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when
 taking cgr_lock

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...o.com>
> Sent: Monday, April 3, 2023 18:22
> To: Vladimir Oltean <vladimir.oltean@....com>
> Cc: Leo Li <leoyang.li@....com>; linuxppc-dev@...ts.ozlabs.org; linux-arm-
> kernel@...ts.infradead.org; Scott Wood <oss@...error.net>; Camelia
> Alexandra Groza <camelia.groza@....com>; linux-kernel@...r.kernel.org;
> Roy Pledge <roy.pledge@....com>; David S . Miller
> <davem@...emloft.net>; Claudiu Manoil <claudiu.manoil@....com>
> Subject: Re: [PATCH v2 1/2] soc: fsl: qbman: Always disable interrupts when
> taking cgr_lock
> 
> On 4/3/23 10:02, Vladimir Oltean wrote:
> > On Fri, Mar 31, 2023 at 11:14:12AM -0400, Sean Anderson wrote:
> >> smp_call_function_single disables IRQs when executing the callback. To
> >> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> >> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> >> other lockers.
> >>
> >> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
> >
> > If you've identified smp_call_function_single() as the problem, then the
> > true issue seems to lie in commit 96f413f47677 ("soc/fsl/qbman: fix
> > issue in qman_delete_cgr_safe()") and not in the initial commit, no?
> 
> Yes, that seems better. I did a blame and saw that qman_delete_cgr_safe
> had been around since the initial driver, but I didn't realize it worked
> in a different way back then.
> 
> --Sean
> 
> > Anyway,
> >
> > Tested-by: Vladimir Oltean <vladimir.oltean@....com>

Apart from Vladimir's comment:
Reviewed-by: Camelia Groza <camelia.groza@....com>