linux-kernel - Re: [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_1A9532B54AD0FB644D7A28B39C5FF9B34506@qq.com>
Date:   Thu, 6 Apr 2023 03:40:15 +0800
From:   Wen Yang <wenyang.linux@...mail.com>
To:     Jens Axboe <axboe@...nel.dk>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Eric Biggers <ebiggers@...gle.com>, Christoph Hellwig <hch@....de>,
        Dylan Yudaken <dylany@...com>,
        David Woodhouse <dwmw@...zon.co.uk>, Fu Wei <wefu@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Michal Nazarewicz <m.nazarewicz@...sung.com>,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] eventfd: use
 wait_event_interruptible_locked_irq() helper


在 2023/4/6 03:26, Jens Axboe 写道:
> On 4/5/23 1:20 PM, wenyang.linux@...mail.com wrote:
>> From: Wen Yang <wenyang.linux@...mail.com>
>>
>> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
>> ("wait_event_interruptible_locked() interface"), but older code such as
>> eventfd_{write,read} still uses the open code implementation.
>> Inspired by commit 8120a8aadb20
>> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
>> patch replaces the open code implementation with a single macro call.
>>
>> No functional change intended.
> Looks pretty reasonable to me. How did you test it?
>
Thanks.

We have verified it in some local testing environments, and the 
intel-lab-lkp has also tested it more than a month, as follows:

https://github.com/intel-lab-lkp/linux/tree/wenyang-linux-foxmail-com/eventfd-use-wait_event_interruptible_locked_irq-helper/20230217-023039

--

Best wishes,

Wen