linux-kernel - Re: [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f539e49e-d831-2ab1-6344-f37f909895ea@kernel.dk>
Date:   Wed, 5 Apr 2023 13:54:56 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Wen Yang <wenyang.linux@...mail.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Eric Biggers <ebiggers@...gle.com>, Christoph Hellwig <hch@....de>,
        Dylan Yudaken <dylany@...com>,
        David Woodhouse <dwmw@...zon.co.uk>, Fu Wei <wefu@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Michal Nazarewicz <m.nazarewicz@...sung.com>,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christian Brauner <brauner@...nel.org>
Subject: Re: [RESEND PATCH v2] eventfd: use
 wait_event_interruptible_locked_irq() helper

On 4/5/23 1:40 PM, Wen Yang wrote:
> 
> 在 2023/4/6 03:26, Jens Axboe 写道:
>> On 4/5/23 1:20 PM, wenyang.linux@...mail.com wrote:
>>> From: Wen Yang <wenyang.linux@...mail.com>
>>>
>>> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
>>> ("wait_event_interruptible_locked() interface"), but older code such as
>>> eventfd_{write,read} still uses the open code implementation.
>>> Inspired by commit 8120a8aadb20
>>> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
>>> patch replaces the open code implementation with a single macro call.
>>>
>>> No functional change intended.
>> Looks pretty reasonable to me. How did you test it?
>>
> Thanks.
> 
> We have verified it in some local testing environments, and the intel-lab-lkp has also tested it more than a month, as follows:
> 
> https://github.com/intel-lab-lkp/linux/tree/wenyang-linux-foxmail-com/eventfd-use-wait_event_interruptible_locked_irq-helper/20230217-023039

Nice, you can add my:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

to it as well. Adding Christian as well, as I guess this should go
through his/al/vfs tree.

-- 
Jens Axboe