linux-kernel - Re: [PATCH v2 2/4] clk: hisilicon: Use helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43a469322f1557feb252a08bd4a42f03.sboyd@kernel.org>
Date:   Wed, 05 Apr 2023 14:06:49 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     David Yang <mmyangfl@...il.com>, linux-clk@...r.kernel.org
Cc:     David Yang <mmyangfl@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org,
        Conor Dooley <conor.dooley@...rochip.com>,
        Nick Alcock <nick.alcock@...cle.com>
Subject: Re: [PATCH v2 2/4] clk: hisilicon: Use helper functions

Quoting David Yang (2023-03-29 00:50:51)
> Remove redundant codes.
> 
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
>  drivers/clk/hisilicon/clk-hi3519.c      | 134 ++----------
>  drivers/clk/hisilicon/clk-hi3559a.c     | 228 +++-----------------
>  drivers/clk/hisilicon/clk-hi3660.c      | 207 ++++++------------
>  drivers/clk/hisilicon/clk-hi3670.c      | 270 +++++++++---------------
>  drivers/clk/hisilicon/crg-hi3516cv300.c | 177 ++--------------
>  drivers/clk/hisilicon/crg-hi3798cv200.c | 206 +++---------------

Maybe you can do this file by file in a different patch? And the commit
text can say that you're migrating to the new way of registering clks
with a device pointer?

>  drivers/clk/hisilicon/crg.h             |   6 -
>  7 files changed, 260 insertions(+), 968 deletions(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
> index ad0c7f350cf0..199d1b8c3140 100644
> --- a/drivers/clk/hisilicon/clk-hi3519.c
> +++ b/drivers/clk/hisilicon/clk-hi3519.c
> @@ -6,11 +6,13 @@
>   */
>  
>  #include <dt-bindings/clock/hi3519-clock.h>
> -#include <linux/clk-provider.h>

It's still a clk provider. Keep this include.

> +
> +#include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/platform_device.h>

Also still a platform driver. Keep this include.

> +#include <linux/of_device.h>

Not sure what this include is for.

> +
>  #include "clk.h"
> -#include "reset.h"
> +#include "crg.h"