linux-kernel - Re: [PATCH v5 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230405085831.GA26156@varda-linux.qualcomm.com>
Date:   Wed, 5 Apr 2023 14:28:32 +0530
From:   Varadarajan Narayanan <quic_varada@...cinc.com>
To:     Johan Hovold <johan@...nel.org>
CC:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
        <kishon@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <gregkh@...uxfoundation.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>,
        <quic_wcheng@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v5 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes

On Fri, Mar 31, 2023 at 12:19:10PM +0200, Johan Hovold wrote:
> On Fri, Mar 31, 2023 at 02:57:11PM +0530, Varadarajan Narayanan wrote:
> > On Thu, Mar 30, 2023 at 12:44:40PM +0300, Dmitry Baryshkov wrote:
> > > On Thu, 30 Mar 2023 at 11:42, Varadarajan Narayanan
> > > <quic_varada@...cinc.com> wrote:
> > > >
> > > > Add USB phy and controller related nodes
> > > >
> > > > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > > > ---
> > > >  Changes in v5:
> > > >         - Fix additional comments
> > > >         - Edit nodes to match with qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > >         - 'make dtbs_check' giving the following messages since
> > > >           ipq9574 doesn't have power domains. Hope this is ok
> > > >
> > > >                 /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@...00: 'power-domains' is a required property
> > > >                 From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> > > >                 /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@...0000: 'power-domains' is a required property
> > > >                 From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > >
> > > No, I think it is not.
> >
> > There are no GDSCs in IPQ9574. Can you suggest how to proceed.
>
> You need to update the binding and either make the power domains
> property optional in the binding or dependent on the SoC.
>
> > > > +               ssphy_0: phy@...00 {
> > >
> > > Nit: usually the label usb_0_qmpphy
> > >
> > > > +                       compatible = "qcom,ipq9574-qmp-usb3-phy";
> > > > +                       reg = <0x0007d000 0xa00>;
> > > > +                       #phy-cells = <0>;
> > > > +
> > > > +                       clocks = <&gcc GCC_USB0_AUX_CLK>,
> > > > +                                <&xo_board_clk>,
> > > > +                                <&gcc GCC_USB0_PHY_CFG_AHB_CLK>,
> > > > +                                <&gcc GCC_USB0_PIPE_CLK>;
> > > > +                       clock-names = "aux",
> > > > +                                     "ref",
> > > > +                                     "com_aux",
>
> This is not the right name for this clock so you need to update the
> binding first.
>
> Please be more careful.

Thanks for your feedback. Have posted v6 with the above corrections.

-Varada
>
> > > > +                                     "pipe";
> > > > +
> > > > +                       resets = <&gcc GCC_USB0_PHY_BCR>,
> > > > +                                <&gcc GCC_USB3PHY_0_PHY_BCR>;
> > > > +                       reset-names = "phy",
> > > > +                                     "phy_phy";
> > > > +
> > > > +                       vdda-pll-supply = <&reg_usb_1p8>;
> > > > +                       vdda-phy-supply = <&reg_usb_0p925>;
> > > > +
> > > > +                       status = "disabled";
> > > > +
> > > > +                       #clock-cells = <0>;
> > > > +                       clock-output-names = "usb0_pipe_clk";
> > > > +               };
>
> Johan