linux-kernel - Re: [PATCH v5 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Apr 2023 11:11:01 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Varadarajan Narayanan <quic_varada@...cinc.com>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, vkoul@...nel.org,
        kishon@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, gregkh@...uxfoundation.org,
        mturquette@...libre.com, sboyd@...nel.org, quic_wcheng@...cinc.com,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v5 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes

On Wed, Apr 05, 2023 at 02:28:32PM +0530, Varadarajan Narayanan wrote:
> On Fri, Mar 31, 2023 at 12:19:10PM +0200, Johan Hovold wrote:

> > > > > +               ssphy_0: phy@...00 {
> > > >
> > > > Nit: usually the label usb_0_qmpphy
> > > >
> > > > > +                       compatible = "qcom,ipq9574-qmp-usb3-phy";
> > > > > +                       reg = <0x0007d000 0xa00>;
> > > > > +                       #phy-cells = <0>;
> > > > > +
> > > > > +                       clocks = <&gcc GCC_USB0_AUX_CLK>,
> > > > > +                                <&xo_board_clk>,
> > > > > +                                <&gcc GCC_USB0_PHY_CFG_AHB_CLK>,
> > > > > +                                <&gcc GCC_USB0_PIPE_CLK>;
> > > > > +                       clock-names = "aux",
> > > > > +                                     "ref",
> > > > > +                                     "com_aux",
> >
> > This is not the right name for this clock so you need to update the
> > binding first.
> >
> > Please be more careful.
> 
> Thanks for your feedback. Have posted v6 with the above corrections.

Thanks for the heads up. But for future submission, please try to
remember to add people that have provided feedback on CC when posting
new revisions.

Johan