linux-kernel - Re: [PATCH v1 07/14] extcon: Use unique number for the extcon device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Apr 2023 18:03:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Chanwoo Choi <cwchoi00@...il.com>
Cc:     Bumwoo Lee <bw365.lee@...sung.com>, linux-kernel@...r.kernel.org,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v1 07/14] extcon: Use unique number for the extcon device
 ID

On Mon, Apr 03, 2023 at 11:52:46PM +0900, Chanwoo Choi wrote:
> On 23. 3. 22. 23:39, Andy Shevchenko wrote:

...

> > +	ret = ida_simple_get(&extcon_dev_ids, 0, INT_MAX, GFP_KERNEL);
> 
> 
> ida_simple_get and ida_simple_remove are deprecated on 
> commit 3264ceec8f17 ("lib/idr.c: document that ida_simple_{get,remove}()
> are deprecated"). Instead of them, better to use ida_alloc and ida_free 
> according to the comments.

Done for v2.

...

> > +	ida_simple_remove(&extcon_dev_ids, edev->id);
> 
> ditto.

Ditto.

-- 
With Best Regards,
Andy Shevchenko