linux-kernel - Re: [PATCH] correct uart_B and uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 17:28:54 +0200
From:   neil.armstrong@...aro.org
To:     hfdevel@....net, khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] correct uart_B and uart_C clock references for meson8b

Hi,

On 06/04/2023 11:33, hfdevel@....net wrote:
> commit b3b6a88d2347d2ec9075603920e616836cb46750
> Author: Hans-Frieder Vogt <hfdevel@....net>
> Date:   Thu Apr 6 10:21:49 2023 +0200
> 
>      [PATCH] correct uart_B and uart_C clock references for meson8b

The subject is wrong, should be: "ARM: dts: meson8b: " and you should also CC the linux-amlogic & linux-arm-kernel MLs likes get_maintainers indicates.

Neil

> 
> with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks.
> This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts.
> 
> Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
> ---
>   meson8b.dtsi |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d5a3fe21e8e7..25f7c985f9ea 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -740,13 +740,13 @@ &uart_A {
> 
>   &uart_B {
>   	compatible = "amlogic,meson8b-uart";
> -	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
> +	clocks = <&xtal>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>;
>   	clock-names = "xtal", "pclk", "baud";
>   };
> 
>   &uart_C {
>   	compatible = "amlogic,meson8b-uart";
> -	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
> +	clocks = <&xtal>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
>   	clock-names = "xtal", "pclk", "baud";
>   };
>