linux-kernel - Re: [PATCH v2 1/8] regulator: dt-bindings: fcs,fan53555: Add support for RK860X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04d7dd35-6648-7ebb-4674-54c132294628@linaro.org>
Date:   Thu, 6 Apr 2023 20:14:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Joseph Chen <chenjh@...k-chips.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v2 1/8] regulator: dt-bindings: fcs,fan53555: Add support
 for RK860X

On 06/04/2023 19:17, Cristian Ciocaltea wrote:
> Add compatibles to support Rockchip RK860X regulators.
> 
> RK8600/RK8601 are pretty similar to the FAN53555 regulators, while
> RK8602/RK8603 are a bit different, having a wider voltage selection
> range.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
>  .../bindings/regulator/fcs,fan53555.yaml      | 22 ++++++++++++++-----
>  1 file changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> index c0dbba843f70..7547c130ff7d 100644
> --- a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> @@ -14,12 +14,22 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fcs,fan53555
> -      - fcs,fan53526
> -      - silergy,syr827
> -      - silergy,syr828
> -      - tcs,tcs4525
> +    oneOf:
> +      - items:

Drop items here. It's just an enum.

> +          - enum:
> +              - fcs,fan53555
> +              - fcs,fan53526
> +              - rockchip,rk8600
> +              - rockchip,rk8602
> +              - silergy,syr827
> +              - silergy,syr828
> +              - tcs,tcs4525
> +      - items:
> +          - const: rockchip,rk8601
> +          - const: rockchip,rk8600
> +      - items:
> +          - const: rockchip,rk8603
> +          - const: rockchip,rk8602
>  
>    reg:
>      maxItems: 1

Best regards,
Krzysztof