linux-kernel - Re: [PATCH v2 8/8] regulator: fan53555: Add support for RK860X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16bf1f2e-474d-f2ce-a1c9-2f6a089199d5@linaro.org>
Date:   Thu, 6 Apr 2023 20:15:05 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Joseph Chen <chenjh@...k-chips.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v2 8/8] regulator: fan53555: Add support for RK860X

On 06/04/2023 19:18, Cristian Ciocaltea wrote:
> Extend the existing fan53555 driver to support the Rockchip RK860X
> regulators.
> 
> RK8600/RK8601 are pretty similar to the FAN53555 regulators.
> 
> RK8602/RK8603 are a bit different, having a wider output voltage
> selection range, from 0.5 V to 1.5 V in 6.25 mV steps. They also use
> additional VSEL0/VSEL1 registers for the voltage selector, but the
> enable and mode bits are still located in the original FAN53555 specific
> VSEL0/VSEL1 registers.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
>  drivers/regulator/fan53555.c | 121 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 118 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
> index acf14ba7aaa6..130f3dbe9840 100644
> --- a/drivers/regulator/fan53555.c
> +++ b/drivers/regulator/fan53555.c
> @@ -26,6 +26,9 @@
>  #define FAN53555_VSEL0		0x00
>  #define FAN53555_VSEL1		0x01
>  
> +#define RK8602_VSEL0		0x06
> +#define RK8602_VSEL1		0x07
> +
>  #define TCS4525_VSEL0		0x11
>  #define TCS4525_VSEL1		0x10
>  #define TCS4525_TIME		0x13
> @@ -55,6 +58,7 @@
>  
>  #define FAN53555_NVOLTAGES	64	/* Numbers of voltages */
>  #define FAN53526_NVOLTAGES	128
> +#define RK8602_NVOLTAGES	160
>  
>  #define TCS_VSEL0_MODE		BIT(7)
>  #define TCS_VSEL1_MODE		BIT(6)
> @@ -64,6 +68,8 @@
>  enum fan53555_vendor {
>  	FAN53526_VENDOR_FAIRCHILD = 0,
>  	FAN53555_VENDOR_FAIRCHILD,
> +	FAN53555_VENDOR_ROCKCHIP,	/* RK8600, RK8601 */
> +	RK8602_VENDOR_ROCKCHIP,		/* RK8602, RK8603 */


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof