linux-kernel - Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202304061003.e5e0dc9c-yujie.liu@intel.com>
Date:   Thu, 6 Apr 2023 10:51:13 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Waiman Long <longman@...hat.com>
CC:     <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        <cgroups@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan.x@...edance.com>,
        "Johannes Weiner" <hannes@...xchg.org>,
        Christian Brauner <brauner@...nel.org>,
        <linux-kernel@...r.kernel.org>, Juri Lelli <juri.lelli@...hat.com>,
        "Dietmar Eggemann" <dietmar.eggemann@....com>,
        <gscrivan@...hat.com>, Waiman Long <longman@...hat.com>
Subject: Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle
 CLONE_INTO_CGROUP properly

Hello,

kernel test robot noticed "WARNING:suspicious_RCU_usage" on:

commit: a53ab2ba098e6839db602212831c8b62a38c2956 ("[PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly")
url: https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/cgroup-cpuset-Make-cpuset_fork-handle-CLONE_INTO_CGROUP-properly/20230331-225527
base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git 62bad54b26db8bc98e28749cd76b2d890edb4258
patch link: https://lore.kernel.org/all/20230331145045.2251683-2-longman@redhat.com/
patch subject: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly

in testcase: boot

compiler: gcc-11
test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

(please refer to attached dmesg/kmsg for entire log/backtrace)


If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <yujie.liu@...el.com>
| Link: https://lore.kernel.org/oe-lkp/202304061003.e5e0dc9c-yujie.liu@intel.com


[    2.798551][    T2] WARNING: suspicious RCU usage
[    2.799473][    T2] 6.3.0-rc4-00162-ga53ab2ba098e #1 Not tainted
[    2.799901][    T2] -----------------------------
[    2.800551][    T2] include/linux/cgroup.h:437 suspicious rcu_dereference_check() usage!
[    2.802044][    T2]
[    2.802044][    T2] other info that might help us debug this:
[    2.802044][    T2]
[    2.803158][    T2]
[    2.803158][    T2] rcu_scheduler_active = 1, debug_locks = 1
[    2.804024][    T2] 1 lock held by kthreadd/2:
[ 2.804851][ T2] #0: ffffffff84c38230 (cgroup_threadgroup_rwsem){.+.+}-{0:0}, at: cgroup_can_fork (kernel/cgroup/cgroup.c:6515) 
[    2.806112][    T2]
[    2.806112][    T2] stack backtrace:
[    2.806958][    T2] CPU: 0 PID: 2 Comm: kthreadd Not tainted 6.3.0-rc4-00162-ga53ab2ba098e #1
[    2.807537][    T2] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014
[    2.807537][    T2] Call Trace:
[    2.807537][    T2]  <TASK>
[ 2.807537][ T2] dump_stack_lvl (lib/dump_stack.c:107) 
[ 2.807537][ T2] lockdep_rcu_suspicious (include/linux/context_tracking.h:153 kernel/locking/lockdep.c:6600) 
[ 2.807537][ T2] cpuset_fork (include/linux/cgroup.h:437 kernel/cgroup/cpuset.c:240 kernel/cgroup/cpuset.c:3262) 
[ 2.807537][ T2] cgroup_post_fork (kernel/cgroup/cgroup.c:6635 (discriminator 6)) 
[ 2.807537][ T2] ? cgroup_cancel_fork (kernel/cgroup/cgroup.c:6573) 
[ 2.807537][ T2] ? mark_held_locks (kernel/locking/lockdep.c:4237) 
[ 2.807537][ T2] ? lockdep_hardirqs_on_prepare (kernel/locking/lockdep.c:4529) 
[ 2.807537][ T2] copy_process (kernel/fork.c:2499) 
[ 2.807537][ T2] ? __cleanup_sighand (kernel/fork.c:2013) 
[ 2.807537][ T2] ? __lock_acquire (kernel/locking/lockdep.c:186 kernel/locking/lockdep.c:3836 kernel/locking/lockdep.c:5056) 
[ 2.807537][ T2] kernel_clone (include/linux/random.h:26 kernel/fork.c:2680) 
[ 2.807537][ T2] ? create_io_thread (kernel/fork.c:2639) 
[ 2.807537][ T2] ? mark_usage (kernel/locking/lockdep.c:4914) 
[ 2.807537][ T2] ? finish_task_switch+0x21c/0x910 
[ 2.807537][ T2] ? __switch_to (arch/x86/include/asm/bitops.h:55 include/asm-generic/bitops/instrumented-atomic.h:29 include/linux/thread_info.h:89 arch/x86/include/asm/fpu/sched.h:65 arch/x86/kernel/process_64.c:623) 
[ 2.807537][ T2] kernel_thread (kernel/fork.c:2729) 
[ 2.807537][ T2] ? __ia32_sys_clone3 (kernel/fork.c:2729) 
[ 2.807537][ T2] ? lock_downgrade (kernel/locking/lockdep.c:5321) 
[ 2.807537][ T2] ? kthread_complete_and_exit (kernel/kthread.c:331) 
[ 2.807537][ T2] ? do_raw_spin_unlock (arch/x86/include/asm/atomic.h:29 include/linux/atomic/atomic-instrumented.h:28 include/asm-generic/qspinlock.h:57 kernel/locking/spinlock_debug.c:100 kernel/locking/spinlock_debug.c:140) 
[ 2.807537][ T2] kthreadd (kernel/kthread.c:400 kernel/kthread.c:746) 
[ 2.807537][ T2] ? kthread_is_per_cpu (kernel/kthread.c:719) 
[ 2.807537][ T2] ret_from_fork (arch/x86/entry/entry_64.S:314) 
[    2.807537][    T2]  </TASK>


-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config-6.3.0-rc4-00162-ga53ab2ba098e" of type "text/plain" (161669 bytes)

View attachment "job-script" of type "text/plain" (4721 bytes)

Download attachment "dmesg.xz" of type "application/x-xz" (28864 bytes)