linux-kernel - Re: Litmus test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea9376b4-4b3d-48ee-9c27-ad8de8a7b5cb@paulmck-laptop>
Date:   Thu, 6 Apr 2023 15:34:54 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Joel Fernandes <joel@...lfernandes.org>,
        linux-kernel@...r.kernel.org, Boqun Feng <boqun.feng@...il.com>,
        Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will.deacon@....com>,
        Jonas Oberhauser <jonas.oberhauser@...weicloud.com>,
        Akira Yokosawa <akiyks@...il.com>,
        Andrea Parri <parri.andrea@...il.com>,
        Daniel Lustig <dlustig@...dia.com>,
        David Howells <dhowells@...hat.com>,
        Jonas Oberhauser <jonas.oberhauser@...wei.com>,
        linux-arch@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>,
        Paul Heidekrüger <paul.heidekrueger@...tum.de>,
        Will Deacon <will@...nel.org>
Subject: Re: Litmus test names

On Thu, Apr 06, 2023 at 05:36:13PM -0400, Alan Stern wrote:
> Paul:
> 
> I just saw that two of the files in tools/memory-model/litmus-tests have 
> almost identical names:
> 
> 	Z6.0+pooncelock+pooncelock+pombonce.litmus
> 	Z6.0+pooncelock+poonceLock+pombonce.litmus
> 
> They differ only by a lower-case 'l' vs. a capital 'L'.  It's not at all 
> easy to see, and won't play well in case-insensitive filesystems.
> 
> Should one of them be renamed?

Quite possibly!

The "L" denotes smp_mb__after_spinlock().  The only code difference
between these is that Z6.0+pooncelock+poonceLock+pombonce.litmus has
smp_mb__after_spinlock() and Z6.0+pooncelock+pooncelock+pombonce.litmus
does not.

Suggestions for a better name?  We could capitalize all the letters
in LOCK, I suppose...

							Thanx, Paul