linux-kernel - RE: [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific ioctl config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS4PR10MB5895BA5B2ECFFF74DDBAB571E0919@AS4PR10MB5895.EURPRD10.PROD.OUTLOOK.COM>
Date:   Thu, 6 Apr 2023 05:17:47 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC:     linux-serial <linux-serial@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/9] tty: n_gsm: add restart parameter to DLC specific
 ioctl config

> > From: Daniel Starke <daniel.starke@...mens.com>
> > 
> > 'gsm_config_ext' already allows to force a link reset via 'restart'
> > parameter.
> 
> Please be more precise, there a function and struct with this name.
> 
> HOWEVER, there is no such parameter in tty-next (am I looking from wrong 
> repo??):
> 
> static int gsm_config_ext(struct gsm_mux *gsm, struct gsm_config_ext *ce)
> 
> ...nor here:
> 
> struct gsm_config_ext {
>         __u32 keep_alive;       /* Control channel keep-alive in 1/100th of a
>                                  * second (0 to disable)
>                                  */
>         __u32 wait_config;      /* Wait for DLCI config before opening virtual link? */
>         __u32 reserved[6];      /* For future use, must be initialized to zero */
> };
> 
> ???

You are right. Looks like I was looking at the wrong branch. I will reword
the commit message and deliver the patch for 'struct gsm_config_ext'
afterwards.

Best regards,
Daniel Starke