linux-kernel - RE: [PATCH 3/9] tty: n_gsm: add missing description to gsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Apr 2023 05:26:01 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC:     linux-serial <linux-serial@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/9] tty: n_gsm: add missing description to gsm_config

> > +	unsigned int mru;	/* Maximum incoming frame payload size */
> > +	unsigned int mtu;	/* Maximum outgoing frame payload size */
> 
> I'm used to "payload" referring in networking context to "useful" part of 
> the frame but MTU/MRU probably includes headers too? Maybe just say
> "frame size"?

Just frame size is incorrect, as the basic/advanced option mode header and
byte stuffing do not count against this number. See 'gsm0_receive' and
'gsm1_receive' and also ch. 5.7.2 of the standard. The outgoing limit is
applied in 'gsm_dlci_data_output' and 'gsm_dlci_data_output_framed'.

Link: https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516

Best regards,
Daniel Starke