linux-kernel - Re: [PATCH v3] sched/numa: Fix divide by zero for sysctl_numa_balancing_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZC5tNK50QouEvX7Q@chenyu5-mobl1>
Date:   Thu, 6 Apr 2023 14:56:52 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     chris hyser <chris.hyser@...cle.com>
CC:     <linux-kernel@...r.kernel.org>, <dietmar.eggemann@....com>,
        <peterz@...radead.org>, <vincent.guittot@...aro.org>
Subject: Re: [PATCH v3] sched/numa: Fix divide by zero for
 sysctl_numa_balancing_scan_size.

On 2023-04-04 at 14:29:15 -0400, chris hyser wrote:
> Commit 6419265899d9 ("sched/fair: Fix division by zero
> sysctl_numa_balancing_scan_size") prevented a divide by zero by using
> sysctl mechanisms to return EINVAL for a sysctl_numa_balancing_scan_size
> value of zero. When moved from a sysctl to a debugfs file, this checking
> was lost.
> 
> This patch puts zero checking back in place.
> 
Maybe add a tag
Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")
> Signed-off-by: Chris Hyser <chris.hyser@...cle.com>

Other than that,
Tested-by: Chen Yu <yu.c.chen@...el.com>

thanks,
Chenyu