linux-kernel - Re: [PATCH v3] sched/numa: Fix divide by zero for sysctl_numa_balancing_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f063cfc8-805e-4d73-4c62-ff1bac4b1ed3@oracle.com>
Date:   Thu, 6 Apr 2023 11:30:14 -0400
From:   chris hyser <chris.hyser@...cle.com>
To:     Chen Yu <yu.c.chen@...el.com>
Cc:     linux-kernel@...r.kernel.org, dietmar.eggemann@....com,
        peterz@...radead.org, vincent.guittot@...aro.org
Subject: Re: [PATCH v3] sched/numa: Fix divide by zero for
 sysctl_numa_balancing_scan_size.

On 4/6/23 02:56, Chen Yu wrote:
> On 2023-04-04 at 14:29:15 -0400, chris hyser wrote:
>> Commit 6419265899d9 ("sched/fair: Fix division by zero
>> sysctl_numa_balancing_scan_size") prevented a divide by zero by using
>> sysctl mechanisms to return EINVAL for a sysctl_numa_balancing_scan_size
>> value of zero. When moved from a sysctl to a debugfs file, this checking
>> was lost.
>>
>> This patch puts zero checking back in place.
>>
> Maybe add a tag
> Fixes: 8a99b6833c88 ("sched: Move SCHED_DEBUG sysctl to debugfs")

Yes, you are correct. I should have reviewed the patch submitter doc. 
Also seems like a Cc: to stable is appropriate.

>> Signed-off-by: Chris Hyser <chris.hyser@...cle.com>
> 
> Other than that,
> Tested-by: Chen Yu <yu.c.chen@...el.com>
> 
> thanks,
> Chenyu

Thank you. Changes made and sent as v4.

-chrish