linux-kernel - Re: [PATCH 2/2] erofs: remove unnecessary kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230406094128.36587-1-frank.li@vivo.com>
Date:   Thu,  6 Apr 2023 17:41:28 +0800
From:   Yangtao Li <frank.li@...o.com>
To:     hsiangkao@...ux.alibaba.com
Cc:     chao@...nel.org, frank.li@...o.com, huyue2@...lpad.com,
        jefflexu@...ux.alibaba.com, linux-erofs@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, xiang@...nel.org
Subject: Re: [PATCH 2/2] erofs: remove unnecessary kobject_del()

HI Gao Xiang,

> Would you mind taking a look at
> commit a942da24abc5 ("fs: erofs: add sanity check for kobject in erofs_unregister_sysfs")
>
> , which could be "git-blame"ed (I'd suggest looking into these
> blame first), and the related discussion was:
>
> https://lore.kernel.org/r/CAD-N9QXNx=p3-QoWzk6pCznF32CZy8kM3vvo8mamfZZ9CpUKdw@mail.gmail.com
> https://lore.kernel.org/r/20220315075152.63789-1-dzm91@hust.edu.cn

> TL;DR: I guess it could be fixed as below if kobject_del() could
> : be killed safely:
>
> 	if (sbi->s_kobj.state_in_sysfs) {
> 		kobject_put(&sbi->s_kobj);
> 		wait_for_completion(&sbi->s_kobj_unregister);
> 	}

Thanks for your review and detailed explanation.

MBR,
Yangtao