linux-kernel - [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com>
Date:   Fri, 7 Apr 2023 23:02:05 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start

When loading the driver for rtl8192e, the W_DISABLE# switch is working 
as intended. But when the WLAN is turned off in software and then turned 
on again the W_DISABLE# does not work anymore.

Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio()
checking this every two seconds is an conditional return.

	if (priv->bfirst_after_down) {
		priv->bfirst_after_down = true; // PH: useless line
		return;
	}

	tmp1byte = rtl92e_readb(dev, GPI); // PH: GPI for W_DISABLE#

bfirst_after_down is set true when switching the WLAN off in software. 
But it is not set to false again when WLAN is turned on again.

Thanks for your support.

Bye Philipp