linux-kernel - Re: [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f71b782-e52e-48cb-9a41-4097a3329ae3@kili.mountain>
Date:   Thu, 13 Apr 2023 12:34:15 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [BUG] staging: rtl8192e: W_DISABLE# does not work after
 stop/start

On Fri, Apr 07, 2023 at 11:02:05PM +0200, Philipp Hortmann wrote:
> When loading the driver for rtl8192e, the W_DISABLE# switch is working as
> intended. But when the WLAN is turned off in software and then turned on
> again the W_DISABLE# does not work anymore.
> 
> Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio()
> checking this every two seconds is an conditional return.
> 
> 	if (priv->bfirst_after_down) {
> 		priv->bfirst_after_down = true; // PH: useless line
> 		return;
> 	}
> 
> 	tmp1byte = rtl92e_readb(dev, GPI); // PH: GPI for W_DISABLE#
> 
> bfirst_after_down is set true when switching the WLAN off in software. But
> it is not set to false again when WLAN is turned on again.
> 

Is there a question here?  You're like the expert on this driver and you
seem to have figured out the solution...  I'm confused.

regards,
dan carpenter