linux-kernel - Re: [PATCH 29/32] fpga: dfl: Assign parent for event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZC+7a/hUe1qpUsDv@yilunxu-OptiPlex-7050>
Date:   Fri, 7 Apr 2023 14:42:51 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
        linuxarm@...wei.com, Dan Williams <dan.j.williams@...el.com>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Jiucheng Xu <jiucheng.xu@...ogic.com>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Robert Richter <rric@...nel.org>,
        Atish Patra <atishp@...shpatra.org>,
        Anup Patel <anup@...infault.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Frank Li <Frank.li@....com>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Vineet Gupta <vgupta@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Dave Jiang <dave.jiang@...el.com>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Liang Kan <kan.liang@...ux.intel.com>
Subject: Re: [PATCH 29/32] fpga: dfl: Assign parent for event_source device

On 2023-04-04 at 14:42:22 +0100, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the Platform device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Cc: Wu Hao <hao.wu@...el.com>
> Cc: Tom Rix <trix@...hat.com>
> Cc: linux-fpga@...r.kernel.org
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Reviewed-by: Xu Yilun <yilun.xu@...el.com>

> ---
>  drivers/fpga/dfl-fme-perf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
> index 7422d2bc6f37..2d59f1c620b1 100644
> --- a/drivers/fpga/dfl-fme-perf.c
> +++ b/drivers/fpga/dfl-fme-perf.c
> @@ -912,6 +912,7 @@ static int fme_perf_pmu_register(struct platform_device *pdev,
>  
>  	fme_perf_setup_hardware(priv);
>  
> +	pmu->parent =		&pdev->dev;
>  	pmu->task_ctx_nr =	perf_invalid_context;
>  	pmu->attr_groups =	fme_perf_groups;
>  	pmu->attr_update =	fme_perf_events_groups;
> -- 
> 2.37.2
>