[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5dc4ddc2-9d15-ebb2-38bc-8a544ca67e0d@starfivetech.com>
Date: Fri, 7 Apr 2023 14:58:47 +0800
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Rob Herring <robh@...nel.org>
CC: Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Emil Renner Berthing <kernel@...il.dk>,
Conor Dooley <conor@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Philipp Zabel <p.zabel@...gutronix.de>,
Jack Zhu <jack.zhu@...rfivetech.com>,
<linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
On 2023/4/7 14:54, Krzysztof Kozlowski wrote:
> On 07/04/2023 08:51, Changhuang Liang wrote:
>>>> +
>>>> + resets:
>>>> + items:
>>>> + - description: DPHY_HW reset
>>>> + - description: DPHY_B09_ALWAYS_ON reset
>>>> +
>>>> + starfive,aon-syscon:
>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>>> + items:
>>>> + - items:
>>>> + - description: phandle of AON SYSCON
>>>> + - description: register offset
>>>> + description: The power of dphy rx is configured by AON SYSCON
>>>> + in this property.
>>>
>>> Sounds like AON SYSCON should be a power-domains provider. Custom
>>> phandle links are for things which don't fit standard bindings.
>>>
>>
>> Hi, Rob,
>>
>> On visionfive2 jh7110 SoC, this AON SYSCON is the Secondary power switch to the DPHY Rx.
>> When we open the pmic switch, we also need to configure the AON SYSCON register to turn
>> on the switch, it is used to link the pmic and the DPHY Rx, So I think it just use syscon
>> framework is enought. What about your comments.
>
> Which sounds exactly like power domain provider...
>
OK, thanks for your comment, I will try to use power domain framework in next patch.
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists