[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ef8c686b-dcc7-c423-cc9a-009d10056134@kernel.org>
Date: Fri, 7 Apr 2023 08:59:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: hfdevel@....net, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, neil.armstrong@...aro.org,
khilman@...libre.com, jbrunet@...libre.com,
martin.blumenstingl@...glemail.com
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] ARM: dts: meson8b: correct uart_B and uart_C
clock references
On 06/04/2023 22:06, hfdevel@....net wrote:
> Resending this patch with proper subject line, corrected distribution and reference to what the patch fixes. Thanks, Neil and Martin, for your guidance!
>
> commit b3b6a88d2347d2ec9075603920e616836cb46750
> Author: Hans-Frieder Vogt <hfdevel@....net>
> Date: Thu Apr 6 10:21:49 2023 +0200
>
> [PATCH] correct uart_B and uart_C clock references for meson8b
That's not correct patch format. All this above is not part of patch.
>
> with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks.
Start sentences with capital letter.
> This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> Fixes: 3375aa77135f ("ARM: dts: meson8b: Fix the UART device-tree schema validation")
>
Drop blank line
> Signed-off-by: Hans-Frieder Vogt <hfdevel@....net>
> ---
> meson8b.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Best regards,
Krzysztof
Powered by blists - more mailing lists