linux-kernel - Re: [PATCH 7/8] ext4: remove ext4_block_group and ext4_block_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZC/5iDmCfX5HmJZu@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Date:   Fri, 7 Apr 2023 16:37:52 +0530
From:   Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] ext4: remove ext4_block_group and
 ext4_block_group_offset declaration

On Wed, Mar 22, 2023 at 12:12:19AM +0800, Kemeng Shi wrote:
> For ext4_block_group and ext4_block_group_offset, there are only
> declaration without definition. Just remove them.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Feel free to add:

Reviewed-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>

Regards,
ojaswin

> ---
>  fs/ext4/ext4.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 9b2cfc32cf78..f25f13a357de 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2697,10 +2697,6 @@ extern void ext4_get_group_no_and_offset(struct super_block *sb,
>  extern ext4_group_t ext4_get_group_number(struct super_block *sb,
>  					  ext4_fsblk_t block);
>  
> -extern unsigned int ext4_block_group(struct super_block *sb,
> -			ext4_fsblk_t blocknr);
> -extern ext4_grpblk_t ext4_block_group_offset(struct super_block *sb,
> -			ext4_fsblk_t blocknr);
>  extern int ext4_bg_has_super(struct super_block *sb, ext4_group_t group);
>  extern unsigned long ext4_bg_num_gdb(struct super_block *sb,
>  			ext4_group_t group);
> -- 
> 2.30.0
>