linux-kernel - Re: [PATCH 8/8] ext4: try all groups in ext4_mb_new_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZC/6IJT8NxQTTE27@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Date:   Fri, 7 Apr 2023 16:40:24 +0530
From:   Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] ext4: try all groups in ext4_mb_new_blocks_simple

On Wed, Mar 22, 2023 at 12:12:20AM +0800, Kemeng Shi wrote:
> ext4_mb_new_blocks_simple ignores the group before goal, so it will fail
> if free blocks reside in group before goal. Try all groups to avoid
> unexpected failure.
> Search finishes either if any free block is found or if no available
> blocks are found. Simpliy check "i >= max" to distinguish the above
> cases.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> Suggested-by: Theodore Ts'o <tytso@....edu>
> ---
>  fs/ext4/mballoc.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Feel free to add:

Reviewed-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>

Regards,
ojaswin