linux-kernel - Re: [PATCH 2/8] scripts/mksysmap: remove comments described in nm(1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Apr 2023 11:46:44 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhen Lei <thunder.leizhen@...wei.com>,
        Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nicolas Schier <nicolas@...sle.eu>
Subject: Re: [PATCH 2/8] scripts/mksysmap: remove comments described in nm(1)

On Wed, Mar 8, 2023 at 3:52 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> I do not think we need to repeat what is written in 'man nm'.

I agree, but the paragraphs following the one you removed refer to a,
U, N, w, T, t, and W now with no context that those are the nm
formats.

I'm ok with this patch, but please consider adding a sentence along
the lines of:

The following refers to the symbol type as per nm(1).

>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  scripts/mksysmap | 19 -------------------
>  1 file changed, 19 deletions(-)
>
> diff --git a/scripts/mksysmap b/scripts/mksysmap
> index 16a08b8ef2f8..697fc6653953 100755
> --- a/scripts/mksysmap
> +++ b/scripts/mksysmap
> @@ -10,25 +10,6 @@
>  #####
>  # Generate System.map (actual filename passed as second argument)
>
> -# $NM produces the following output:
> -# f0081e80 T alloc_vfsmnt
> -
> -#   The second row specify the type of the symbol:
> -#   A = Absolute
> -#   B = Uninitialised data (.bss)
> -#   C = Common symbol
> -#   D = Initialised data
> -#   G = Initialised data for small objects
> -#   I = Indirect reference to another symbol
> -#   N = Debugging symbol
> -#   R = Read only
> -#   S = Uninitialised data for small objects
> -#   T = Text code symbol
> -#   U = Undefined symbol
> -#   V = Weak symbol
> -#   W = Weak symbol
> -#   Corresponding small letters are local symbols
> -
>  # For System.map filter away:
>  #   a - local absolute symbols
>  #   U - undefined global symbols
> --
> 2.34.1
>


-- 
Thanks,
~Nick Desaulniers