linux-kernel - Re: [PATCH 1/8] scripts/kallsyms: remove redundant code for omitting U and N

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDBmvJh46Z+k05PR@google.com>
Date:   Fri, 7 Apr 2023 11:53:48 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhen Lei <thunder.leizhen@...wei.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/8] scripts/kallsyms: remove redundant code for omitting
 U and N

On Wed, Mar 08, 2023 at 08:52:36PM +0900, Masahiro Yamada wrote:
> The symbol types 'U' and 'N' are already filtered out by the following
> line in scripts/mksysmap:
> 
>     -e ' [aNUw] '
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
> 
>  scripts/kallsyms.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index ea1e3d3aaa6b..8148e880f78e 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -178,10 +178,7 @@ static bool is_ignored_symbol(const char *name, char type)
>  			return true;
>  	}
>  
> -	if (type == 'U' || type == 'u')
> -		return true;
> -	/* exclude debugging symbols */
> -	if (type == 'N' || type == 'n')
> +	if (type == 'u' || type == 'n')
>  		return true;
>  
>  	if (toupper(type) == 'A') {
> -- 
> 2.34.1
> 
>