linux-kernel - Re: [PATCH 48/68] hwmon: nzxt: constify pointers to hwmon_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jkptl4g7jwhz3mij5wffbw2qlwvxsmnwpqhyalq2ayd76pde2h@jfdw7jisg4at>
Date:   Sat, 8 Apr 2023 07:33:20 -0300
From:   Jonas Malaco <jonas@...tocubo.io>
To:     Aleksandr Mezin <mezin.alexander@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Corbet <corbet@....net>,
        Oded Gabbay <ogabbay@...nel.org>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Aleksa Savic <savicaleksa83@...il.com>,
        Jack Doan <me@...kdoan.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Marius Zachmann <mail@...iuszachmann.de>,
        Wilken Gottwalt <wilken.gottwalt@...teo.net>,
        Pali Rohár <pali@...nel.org>,
        Jean-Marie Verdun <verdun@....com>,
        Nick Hawkins <nick.hawkins@....com>,
        Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
        Clemens Ladisch <clemens@...isch.de>,
        Rudolf Marek <r.marek@...embler.cz>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Derek John Clark <derekjohn.clark@...il.com>,
        Joaquín Ignacio Aramendía 
        <samsagax@...il.com>, Iwona Winiarska <iwona.winiarska@...el.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Michael Walle <michael@...le.cc>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        Daniel Machon <daniel.machon@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Agathe Porte <agathe.porte@...ia.com>,
        Eric Tremblay <etremblay@...tech-controls.com>,
        Robert Marko <robert.marko@...tura.hr>,
        linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        patches@...nsource.cirrus.com, openbmc@...ts.ozlabs.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 48/68] hwmon: nzxt: constify pointers to
 hwmon_channel_info

On Sat, Apr 08, 2023 at 06:14:19AM +0300, Aleksandr Mezin wrote:
> On Thu, Apr 6, 2023 at 11:37 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
> > -static const struct hwmon_channel_info *nzxt_smart2_channel_info[] = {
> > +static const struct hwmon_channel_info * const nzxt_smart2_channel_info[] = {
> 
> In the rest of nzxt-smart2.c there are spaces only before "*", not on
> both sides (and there are a few "*const" already). Would be nice to
> keep it consistent. The same seems to be true for nzxt-kraken2.c
> (although I'm not a maintainer)

While I don't have a strong preference for either `* const` or `*const`,
it would be prefereable to use a single style in any given file.

As the kernel seems to favor the former style:

$ rg -F '*const ' | wc -l
2593
$ rg -F '* const ' | wc -l
15359

it would be better to change the other two locations in nzxt-kraken2.c
to also use `* const`.