lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202304081830.7kKqUkLL-lkp@intel.com>
Date:   Sat, 8 Apr 2023 18:38:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Deepanshu Kartikey <kartikey406@...il.com>,
        gregkh@...uxfoundation.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Deepanshu Kartikey <kartikey406@...il.com>
Subject: Re: [PATCH] Staging: fbtft: fbtft-bus: fixed extra space and
 parenthesis issue

Hi Deepanshu,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Deepanshu-Kartikey/Staging-fbtft-fbtft-bus-fixed-extra-space-and-parenthesis-issue/20230408-130429
patch link:    https://lore.kernel.org/r/20230408050323.70919-1-kartikey406%40gmail.com
patch subject: [PATCH] Staging: fbtft: fbtft-bus: fixed extra space and parenthesis issue
config: i386-randconfig-a002-20230403 (https://download.01.org/0day-ci/archive/20230408/202304081830.7kKqUkLL-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a5c79ed6665465f3101e8251ca030a600cf1ea88
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Deepanshu-Kartikey/Staging-fbtft-fbtft-bus-fixed-extra-space-and-parenthesis-issue/20230408-130429
        git checkout a5c79ed6665465f3101e8251ca030a600cf1ea88
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304081830.7kKqUkLL-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/fbtft/fbtft-bus.c:65:53: error: too few arguments provided to function-like macro invocation
   define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
                                                       ^
   drivers/staging/fbtft/fbtft-bus.c:14:9: note: macro 'define_fbtft_write_reg' defined here
   #define define_fbtft_write_reg(func, buffer_type, data_type, modifier)        \
           ^
>> drivers/staging/fbtft/fbtft-bus.c:65:1: error: unknown type name 'define_fbtft_write_reg'
   define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
   ^
   drivers/staging/fbtft/fbtft-bus.c:67:57: error: too few arguments provided to function-like macro invocation
   define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
                                                           ^
   drivers/staging/fbtft/fbtft-bus.c:14:9: note: macro 'define_fbtft_write_reg' defined here
   #define define_fbtft_write_reg(func, buffer_type, data_type, modifier)        \
           ^
   drivers/staging/fbtft/fbtft-bus.c:67:1: error: unknown type name 'define_fbtft_write_reg'
   define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
   ^
>> drivers/staging/fbtft/fbtft-bus.c:86:3: error: non-void function 'fbtft_write_reg8_bus9' should return a value [-Wreturn-type]
                   return;
                   ^
   drivers/staging/fbtft/fbtft-bus.c:109:3: error: non-void function 'fbtft_write_reg8_bus9' should return a value [-Wreturn-type]
                   return;
                   ^
   6 errors generated.


vim +65 drivers/staging/fbtft/fbtft-bus.c

    64	
  > 65	define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
    66	define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
  > 67	define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
    68	
    69	void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
    70	{
    71		va_list args;
    72		int i, ret;
    73		int pad = 0;
    74		u16 *buf = (u16 *)par->buf;
    75	
    76		if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {
    77			va_start(args, len);
    78			for (i = 0; i < len; i++)
    79				*(((u8 *)buf) + i) = (u8)va_arg(args, unsigned int);
    80			va_end(args);
    81			fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
    82					  par->info->device, u8, buf, len, "%s: ",
    83					  __func__);
    84		}
    85		if (len <= 0)
  > 86			return;
    87	
    88		if (par->spi && (par->spi->bits_per_word == 8)) {
    89			/* we're emulating 9-bit, pad start of buffer with no-ops
    90			 * (assuming here that zero is a no-op)
    91			 */
    92			pad = (len % 4) ? 4 - (len % 4) : 0;
    93			for (i = 0; i < pad; i++)
    94				*buf++ = 0x000;
    95		}
    96	
    97		va_start(args, len);
    98		*buf++ = (u8)va_arg(args, unsigned int);
    99		i = len - 1;
   100		while (i--) {
   101			*buf = (u8)va_arg(args, unsigned int);
   102			*buf++ |= 0x100; /* dc=1 */
   103		}
   104		va_end(args);
   105		ret = par->fbtftops.write(par, par->buf, (len + pad) * sizeof(u16));
   106		if (ret < 0) {
   107			dev_err(par->info->device,
   108				"write() failed and returned %d\n", ret);
   109			return;
   110		}
   111	}
   112	EXPORT_SYMBOL(fbtft_write_reg8_bus9);
   113	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ