linux-kernel - Re: [PATCH] watchdog: s3c2410: remove unused freq_to_wdt and s3c2410wdt_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72a085ff-172f-4378-8ee2-5bf1e47958bf@roeck-us.net>
Date:   Sat, 8 Apr 2023 14:45:36 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Tom Rix <trix@...hat.com>
Cc:     krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com,
        wim@...ux-watchdog.org, nathan@...nel.org, ndesaulniers@...gle.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] watchdog: s3c2410: remove unused freq_to_wdt and
 s3c2410wdt_is_running functions

On Tue, Mar 21, 2023 at 02:34:39PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/watchdog/s3c2410_wdt.c:311:35: error: unused function
>   'freq_to_wdt' [-Werror,-Wunused-function]
> static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb)
>                                   ^
> drivers/watchdog/s3c2410_wdt.c:446:19: error: unused function
>   's3c2410wdt_is_running' [-Werror,-Wunused-function]
> static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt)
>                   ^
> These functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/s3c2410_wdt.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
> index 200ba236a72e..6394dda7a5dc 100644
> --- a/drivers/watchdog/s3c2410_wdt.c
> +++ b/drivers/watchdog/s3c2410_wdt.c
> @@ -308,11 +308,6 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt)
>  				       / S3C2410_WTCON_MAXDIV);
>  }
>  
> -static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb)
> -{
> -	return container_of(nb, struct s3c2410_wdt, freq_transition);
> -}
> -
>  static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask)
>  {
>  	const u32 mask_val = BIT(wdt->drv_data->mask_bit);
> @@ -443,11 +438,6 @@ static int s3c2410wdt_start(struct watchdog_device *wdd)
>  	return 0;
>  }
>  
> -static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt)
> -{
> -	return readl(wdt->reg_base + S3C2410_WTCON) & S3C2410_WTCON_ENABLE;
> -}
> -
>  static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd,
>  				    unsigned int timeout)
>  {