linux-kernel - Re: [PATCH] drm/amd/display: set variable dcn3_14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 10:48:29 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Tom Rix <trix@...hat.com>, harry.wentland@....com,
        sunpeng.li@....com, Rodrigo.Siqueira@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        nicholas.kazlauskas@....com, Jun.Lei@....com,
        Pavle.Kotarac@....com, chiahsuan.chung@....com, duncan.ma@....com,
        Charlene.Liu@....com, muansari@....com
Cc:     dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: set variable dcn3_14_soc
 storage-class-specifier to static

On 4/6/23 14:44, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
>    'dcn3_14_soc' was not declared. Should it be static?
> 
> This variable is only used in one file so should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> index c52b76610bd2..44082f65de1f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> @@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
>   	.dcc_supported = true,
>   };
>   
> -struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
> +static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
>   		/*TODO: correct dispclk/dppclk voltage level determination*/
>   	.clock_limits = {
>   		{
-- 
Hamza