[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e912dd87-f518-bb82-0c18-be4fb2b11b8b@amd.com>
Date: Mon, 10 Apr 2023 10:48:51 -0400
From: Hamza Mahfooz <hamza.mahfooz@....com>
To: Tom Rix <trix@...hat.com>, harry.wentland@....com,
sunpeng.li@....com, Rodrigo.Siqueira@....com,
alexander.deucher@....com, christian.koenig@....com,
Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
Brian.Chang@....com, Martin.Leung@....com, David.Galiffi@....com,
Ethan.Wellenreiter@....com, martin.tsai@....com,
tales.aparecida@...il.com
Cc: dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: set variables aperture_default_system
and context0_default_system storage-class-specifier to static
On 4/6/23 15:58, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol
> 'aperture_default_system' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol
> 'context0_default_system' was not declared. Should it be static?
>
> These variables are only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> index a142a00bc432..bf399819ca80 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c
> @@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp)
> return false;
> }
>
> -uint32_t aperture_default_system = 1;
> -uint32_t context0_default_system; /* = 0;*/
> +static uint32_t aperture_default_system = 1;
> +static uint32_t context0_default_system; /* = 0;*/
>
> static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp,
> struct vm_system_aperture_param *apt)
--
Hamza
Powered by blists - more mailing lists