linux-kernel - Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe1e74a2-e933-7cd9-f740-86d871076191@linaro.org>
Date:   Mon, 10 Apr 2023 18:47:12 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Arnd Bergmann <arnd@...db.de>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Robert Elliott <elliott@....com>,
        Russell King <linux@...linux.org.uk>,
        Stefan Hansson <newbie13xd@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules

On 10/04/2023 14:49, Javier Martinez Canillas wrote:
> Enable zram and dependencies as loadable modules. This allows to use the
> /dev/zramX virtual block devices as swap stored in system memory.
> 
> Options were taken from commit 5c824e8be64d ("ARM: omap2plus_defconfig:
> Enable zram as loadable modules") that does the same for OMAP2+ platforms.

Neither this commit msg nor above omap commit explain why do we want it.
I know what zram is, I know its purpose, but the commit should answer
why we want it in defconfig.

To me it is not a matching defconfig at all:
1. Not a feature related to Exynos hardware,
2. Not needed for basic boot (systemd) or debug.

> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---
> 
>  arch/arm/configs/exynos_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index b0f0baa3a6c4..2d5be864b4ca 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -37,6 +37,8 @@ CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
>  CONFIG_PARTITION_ADVANCED=y
>  CONFIG_CMA=y
> +CONFIG_ZSMALLOC=m
> +CONFIG_PGTABLE_MAPPING=y
>  CONFIG_NET=y
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> @@ -84,6 +86,8 @@ CONFIG_NFC_SHDLC=y
>  CONFIG_NFC_S3FWRN5_I2C=y
>  CONFIG_DEVTMPFS=y
>  CONFIG_DEVTMPFS_MOUNT=y
> +CONFIG_ZRAM=m
> +CONFIG_ZRAM_WRITEBACK=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_BLK_DEV_CRYPTOLOOP=y
>  CONFIG_BLK_DEV_RAM=y
> 
> base-commit: e3adc46da349d4a4cda1c58d8186c5bce0b011fd

BTW, I think the base commit makes sense if it is "well-known commit". I
have latest master and next and commit is unknown.

Best regards,
Krzysztof