linux-kernel - Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfd7sk04.fsf@minerva.mail-host-address-is-not-set>
Date:   Mon, 10 Apr 2023 19:51:55 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-kernel@...r.kernel.org
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Arnd Bergmann <arnd@...db.de>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Robert Elliott <elliott@....com>,
        Russell King <linux@...linux.org.uk>,
        Stefan Hansson <newbie13xd@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules

Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> writes:

> On 10/04/2023 14:49, Javier Martinez Canillas wrote:
>> Enable zram and dependencies as loadable modules. This allows to use the
>> /dev/zramX virtual block devices as swap stored in system memory.
>> 
>> Options were taken from commit 5c824e8be64d ("ARM: omap2plus_defconfig:
>> Enable zram as loadable modules") that does the same for OMAP2+ platforms.
>
> Neither this commit msg nor above omap commit explain why do we want it.
> I know what zram is, I know its purpose, but the commit should answer
> why we want it in defconfig.
>
> To me it is not a matching defconfig at all:
> 1. Not a feature related to Exynos hardware,
> 2. Not needed for basic boot (systemd) or debug.
>

It's needed for basic boot on distros that use swap on zram (i.e: Fedora).

I just had this as a local change to boot an ODROID XU4. But have a custom
defconfig for other boards anyways, so I'll just do the same for this one.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat