linux-kernel - Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 12:30:04 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     paulmck@...nel.org, Willy Tarreau <w@....eu>
Cc:     Mark Brown <broonie@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 1/3] tools/nolibc/stdio: Implement vprintf()

On 4/6/23 12:43, Paul E. McKenney wrote:
> On Thu, Apr 06, 2023 at 08:26:09PM +0200, Willy Tarreau wrote:
>> On Thu, Apr 06, 2023 at 05:19:10PM +0100, Mark Brown wrote:
>>> vprintf() is equivalent to vfprintf() to stdout so implement it as a simple
>>> wrapper for the existing vfprintf(), allowing us to build kselftest.h.
>>>
>>> Suggested-by: Willy Tarreau <w@....eu>
>>> Signed-off-by: Mark Brown <broonie@...nel.org>
>>> ---
>>>   tools/include/nolibc/stdio.h | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/tools/include/nolibc/stdio.h b/tools/include/nolibc/stdio.h
>>> index 96ac8afc5aee..6cbbb52836a0 100644
>>> --- a/tools/include/nolibc/stdio.h
>>> +++ b/tools/include/nolibc/stdio.h
>>> @@ -273,6 +273,12 @@ int vfprintf(FILE *stream, const char *fmt, va_list args)
>>>   	return written;
>>>   }
>>>   
>>> +static __attribute__((unused))
>>> +int vprintf(const char *fmt, va_list args)
>>> +{
>>> +	return vfprintf(stdout, fmt, args);
>>> +}
>>> +
>>>   static __attribute__((unused, format(printf, 2, 3)))
>>>   int fprintf(FILE *stream, const char *fmt, ...)
>>>   {
>>
>> Perfect, thank you Mark, I'm glad that it simplified the rest of
>> your series.
>>
>> Acked-by: Willy Tarreau <w@....eu>
>>
>> Paul, feel free to directly queue this one for 6.5. If you prefer I
>> can as well queue it on my side and send it later, it's just that I
>> have exactly zero extra value on top of this one ;-)
> 
> Alternatively, if it would be more convenient for Mark to send this
> up via kselftest:
> 
> Acked-by: Paul E. McKenney <paulmck@...nel.org>
> 
> It currently merges cleanly with the -rcu tree's dev branch, so this
> should not be a problem.
> 
> Either way, please let me know, Mark!
> 
> 						

I can take these through kselftest or can go through arm64

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah