linux-kernel - Re: [PATCH] clk: mediatek: fhctl: set varaiables fhctl_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2023 16:59:28 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Tom Rix <trix@...hat.com>, angelogioacchino.delregno@...labora.com,
        edward-jw.yang@...iatek.com, johnson.wang@...iatek.com,
        matthias.bgg@...il.com, mturquette@...libre.com, wenst@...omium.org
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] clk: mediatek: fhctl: set varaiables fhctl_offset_v1,2 storage-class-specifier to static

Quoting Tom Rix (2023-04-05 18:09:35)
> smatch reports
> drivers/clk/mediatek/clk-fhctl.c:17:27: warning: symbol
>   'fhctl_offset_v1' was not declared. Should it be static?
> drivers/clk/mediatek/clk-fhctl.c:30:27: warning: symbol
>   'fhctl_offset_v2' was not declared. Should it be static?
> 
> These variables are only used in one file so should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---

Applied to clk-next