linux-kernel - Re: [PATCH v3] firewire: init_ohci1394_dma: use correct function names in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230411000543.GA254125@workstation>
Date:   Tue, 11 Apr 2023 09:05:43 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Stefan Richter <stefanr@...6.in-berlin.de>,
        linux1394-devel@...ts.sourceforge.net,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3] firewire: init_ohci1394_dma: use correct function
 names in comments

On Sun, Apr 09, 2023 at 06:13:06PM -0700, Randy Dunlap wrote:
> Prevent kernel-doc complaints by using the correct function names in
> kernel-doc comments:
> 
> drivers/firewire/init_ohci1394_dma.c:258: warning: expecting prototype for debug_init_ohci1394_dma(). Prototype was for init_ohci1394_dma_on_all_controllers() instead
> drivers/firewire/init_ohci1394_dma.c:289: warning: expecting prototype for setup_init_ohci1394_early(). Prototype was for setup_ohci1394_dma() instead
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Stefan Richter <stefanr@...6.in-berlin.de>
> Cc: linux1394-devel@...ts.sourceforge.net
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Takashi Sakamoto <o-takashi@...amocchi.jp>
> ---
> v2: rebase/resend, add note to Andrew
> v3: add Takashi-san
> 
>  drivers/firewire/init_ohci1394_dma.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thank you to remind it to me.

Acked-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
 
By the way, I got enough access permission to linux1394.git repository
and I'm preparing it for maintenance work (not done yet).

* https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git/

After finishing the preparation (e.g. joining to linux-next integration),
I'll apply your patch and tell it to you, within the week.

> diff -- a/drivers/firewire/init_ohci1394_dma.c b/drivers/firewire/init_ohci1394_dma.c
> --- a/drivers/firewire/init_ohci1394_dma.c
> +++ b/drivers/firewire/init_ohci1394_dma.c
> @@ -251,7 +251,7 @@ static inline void __init init_ohci1394_
>  }
>  
>  /**
> - * debug_init_ohci1394_dma - scan for OHCI1394 controllers and init DMA on them
> + * init_ohci1394_dma_on_all_controllers - scan for OHCI1394 controllers and init DMA on them
>   * Scans the whole PCI space for OHCI1394 controllers and inits DMA on them
>   */
>  void __init init_ohci1394_dma_on_all_controllers(void)
> @@ -283,7 +283,7 @@ void __init init_ohci1394_dma_on_all_con
>  }
>  
>  /**
> - * setup_init_ohci1394_early - enables early OHCI1394 DMA initialization
> + * setup_ohci1394_dma - enables early OHCI1394 DMA initialization
>   */
>  static int __init setup_ohci1394_dma(char *opt)
>  {

Kind regards

Takashi Sakamoto