linux-kernel - Re: [PATCH] tools/mm/page_owner_sort.c: fix TGID output when cull=tg is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230410210141.678bf917bfce759caf9d18df@linux-foundation.org>
Date:   Mon, 10 Apr 2023 21:01:41 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Steve Chou <steve_chou@...i.com.tw>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Jiajian Ye <yejiajian2018@...il.szu.edu.cn>
Subject: Re: [PATCH] tools/mm/page_owner_sort.c: fix TGID output when
 cull=tg is used

On Tue, 11 Apr 2023 11:49:28 +0800 Steve Chou <steve_chou@...i.com.tw> wrote:

> When using cull option with 'tg' flag, the fprintf is using pid instead
> of tgid. It should use tgid instead.
> 
> ...
>
> --- a/tools/mm/page_owner_sort.c
> +++ b/tools/mm/page_owner_sort.c
> @@ -857,7 +857,7 @@ int main(int argc, char **argv)
>  			if (cull & CULL_PID || filter & FILTER_PID)
>  				fprintf(fout, ", PID %d", list[i].pid);
>  			if (cull & CULL_TGID || filter & FILTER_TGID)
> -				fprintf(fout, ", TGID %d", list[i].pid);
> +				fprintf(fout, ", TGID %d", list[i].tgid);
>  			if (cull & CULL_COMM || filter & FILTER_COMM)
>  				fprintf(fout, ", task_comm_name: %s", list[i].comm);
>  			if (cull & CULL_ALLOCATOR) {

Thanks, copy-paste error, I expect.  I'll add Fixes: 9c8a0a8e599
("tools/vm/page_owner_sort.c: support for user-defined culling rules")
and cc:stable.