[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874jpkckxw.fsf@intel.com>
Date: Thu, 13 Apr 2023 10:15:07 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Andrzej Hajda <andrzej.hajda@...el.com>,
Cong Liu <liucong2@...inos.cn>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Matthew Auld <matthew.auld@...el.com>,
Andi Shyti <andi.shyti@...ux.intel.com>,
Nirmoy Das <nirmoy.das@...el.com>,
Matthew Brost <matthew.brost@...el.com>,
Jonathan Cavitt <jonathan.cavitt@...el.com>,
Chris Wilson <chris@...is-wilson.co.uk>,
Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests
On Thu, 13 Apr 2023, Andrzej Hajda <andrzej.hajda@...el.com> wrote:
> On 13.04.2023 05:13, Cong Liu wrote:
A commit message is still needed.
>> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation")
>>
No blank line here.
BR,
Jani.
>> Signed-off-by: Cong Liu <liucong2@...inos.cn>
>> ---
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@...el.com>
>
> Regards
> Andrzej
>> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>> index 5361ce70d3f2..154801f1c468 100644
>> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
>> @@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj)
>>
>> rem = round_up(obj->base.size, BIT(31)) >> 31;
>> /* restricted by sg_alloc_table */
>> - if (overflows_type(rem, unsigned int))
>> + if (overflows_type(rem, unsigned int)) {
>> + kfree(pages);
>> return -E2BIG;
>> + }
>>
>> if (sg_alloc_table(pages, rem, GFP)) {
>> kfree(pages);
>
--
Jani Nikula, Intel Open Source Graphics Center
Powered by blists - more mailing lists