linux-kernel - [PATCH] drm/i915: Fix memory leaks in i915 selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230413075526.221068-1-liucong2@kylinos.cn>
Date:   Thu, 13 Apr 2023 15:55:26 +0800
From:   Cong Liu <liucong2@...inos.cn>
To:     jani.nikula@...ux.intel.com
Cc:     airlied@...il.com, andi.shyti@...ux.intel.com,
        andrzej.hajda@...el.com, chris@...is-wilson.co.uk, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, gwan-gyeong.mun@...el.com,
        intel-gfx@...ts.freedesktop.org, jonathan.cavitt@...el.com,
        joonas.lahtinen@...ux.intel.com, linux-kernel@...r.kernel.org,
        liucong2@...inos.cn, matthew.auld@...el.com,
        matthew.brost@...el.com, mchehab@...nel.org, nirmoy.das@...el.com,
        rodrigo.vivi@...el.com, tvrtko.ursulin@...ux.intel.com
Subject: [PATCH] drm/i915: Fix memory leaks in i915 selftests

This patch fixes memory leaks on error escapes in function fake_get_pages

Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation")
Signed-off-by: Cong Liu <liucong2@...inos.cn>
---
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index 5361ce70d3f2..154801f1c468 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj)
 
 	rem = round_up(obj->base.size, BIT(31)) >> 31;
 	/* restricted by sg_alloc_table */
-	if (overflows_type(rem, unsigned int))
+	if (overflows_type(rem, unsigned int)) {
+		kfree(pages);
 		return -E2BIG;
+	}
 
 	if (sg_alloc_table(pages, rem, GFP)) {
 		kfree(pages);
-- 
2.34.1


No virus found
		Checked by Hillstone Network AntiVirus