[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <4PxhQn3zK1zcbc@panix1.panix.com>
Date: Thu, 13 Apr 2023 01:13:05 +0000
From: pa@...ix.com (Pierre Asselin)
To: pa@...ix.com, javierm@...hat.com
Cc: tzimmermann@...e.de, pa@...ix.com, linux-kernel@...r.kernel.org,
jfalempe@...hat.com, hdegoede@...hat.com,
dri-devel@...ts.freedesktop.org, daniel.vetter@...ll.ch,
ardb@...nel.org
Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is
calculated
After careful reading of the comments in f35cd3fa7729, would this
be an appropriate fix ? Does it still address all the issues raised
by Thomas ?
(not tested)
diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
index 82c64cb9f531..9f5299d54732 100644
--- a/drivers/firmware/sysfb_simplefb.c
+++ b/drivers/firmware/sysfb_simplefb.c
@@ -56,10 +56,11 @@ __init bool sysfb_parse_mode(const struct screen_info *si,
* don't specify alpha channels.
*/
if (si->lfb_depth > 8) {
- bits_per_pixel = max(max3(si->red_size + si->red_pos,
+ bits_per_pixel = max3(max3(si->red_size + si->red_pos,
si->green_size + si->green_pos,
si->blue_size + si->blue_pos),
- si->rsvd_size + si->rsvd_pos);
+ si->rsvd_size + si->rsvd_pos,
+ si->lfb_depth);
} else {
bits_per_pixel = si->lfb_depth;
}
Powered by blists - more mailing lists