linux-kernel - Re: [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2023 12:20:41 -0500
From:   Andrew Davis <afd@...com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE_DATA macro directly

On 4/14/23 12:07 PM, Andy Shevchenko wrote:
> On Thu, Apr 13, 2023 at 04:44:20PM -0500, Andrew Davis wrote:
>> The EXAR_DEVICE macro was converted to use PCI_DEVICE_DATA, having
>> this macro at doesn't add much, remove it.
> 
> I'm not against this, but I have to point out that this patch brings
> inconsistency into the table. Either convert all, or none, I think.
> 

I did notice that, and was not sure how I feel about it either. The
issue is the others in the table have SUBDEVICE_IDs but we have
no simple macro for that.

Maybe what we need is a PCI_DEVICE_SUB_DATA() macro in pci.h, basically
it would be to PCI_DEVICE_SUB() what PCI_DEVICE_DATA() is to PCI_DEVICE().

Then I could re-consistify the table later with that. Thoughts?

Andrew

> That's why the patch that converts EXAR_DEVICE() to use PCI_DEVICE_DATA()
> had a little intrusion.
> 
>