linux-kernel - Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEEkGzoemaSgKovK@kroah.com>
Date:   Thu, 20 Apr 2023 13:38:03 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andrew Davis <afd@...com>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems

On Thu, Apr 13, 2023 at 04:44:21PM -0500, Andrew Davis wrote:
> Possibly the last PCI controller-based (i.e. not a soft/winmodem)
> dial-up modem one can still buy.
> 
> Looks to have a stock XR17C154 PCI UART chip for communication, but for
> some reason when provisioning the PCI IDs they swapped the vendor and
> subvendor IDs. Otherwise this card would have worked out of the box.
> 
> Searching online, some folks seem to not have this issue and others do,
> so it is possible only some batches of cards have this error.
> 
> Create a new macro to handle the switched IDs and add support here.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  drivers/tty/serial/8250/8250_exar.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

Please redo this without patch 1/2 as that would not make sense to
backport anywhere, but adding new device ids are allowed in stable
kernels.  Also, as others pointed out, either convert them all or none
:)

thanks,

greg k-h