linux-kernel - Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db9182f5-b070-0504-ccd1-8ff427ae85ee@ti.com>
Date:   Thu, 20 Apr 2023 10:56:22 -0500
From:   Andrew Davis <afd@...com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems

On 4/20/23 6:38 AM, Greg Kroah-Hartman wrote:
> On Thu, Apr 13, 2023 at 04:44:21PM -0500, Andrew Davis wrote:
>> Possibly the last PCI controller-based (i.e. not a soft/winmodem)
>> dial-up modem one can still buy.
>>
>> Looks to have a stock XR17C154 PCI UART chip for communication, but for
>> some reason when provisioning the PCI IDs they swapped the vendor and
>> subvendor IDs. Otherwise this card would have worked out of the box.
>>
>> Searching online, some folks seem to not have this issue and others do,
>> so it is possible only some batches of cards have this error.
>>
>> Create a new macro to handle the switched IDs and add support here.
>>
>> Signed-off-by: Andrew Davis <afd@...com>
>> ---
>>   drivers/tty/serial/8250/8250_exar.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
> 
> Please redo this without patch 1/2 as that would not make sense to
> backport anywhere, but adding new device ids are allowed in stable
> kernels.  Also, as others pointed out, either convert them all or none
> :)
> 

Fair enough, posting v2 with only the second patch now.

Thanks,
Andrew