linux-kernel - Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84a81f6a-4a35-4b30-8a5a-6cb0eba37594@sirena.org.uk>
Date:   Fri, 14 Apr 2023 12:47:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Patrick Rudolph <patrick.rudolph@...ements.com>
Cc:     Peter Rosin <peda@...ntia.se>, Liam Girdwood <lgirdwood@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

On Fri, Apr 14, 2023 at 01:01:36PM +0200, Patrick Rudolph wrote:

> +	data->supply = devm_regulator_get_optional(dev, "vdd");
> +	if (IS_ERR(data->supply)) {
> +		ret = PTR_ERR(data->supply);

Unless the device can work without power it should be using a normal
regulator_get().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)