linux-kernel - Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALNFmy0RwiyLAAd_vOYxY+yhRn7cnP6Xw=okH17OQ75_vQ3BcA@mail.gmail.com>
Date:   Fri, 14 Apr 2023 14:01:09 +0200
From:   Patrick Rudolph <patrick.rudolph@...ements.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Peter Rosin <peda@...ntia.se>, Liam Girdwood <lgirdwood@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

Hi Mark,
It was using the normal regulator_get() in the last revision, but
Sergey requested to make it optional.
Please advise me what to do here? Who is right?

Regards,
Patrick

On Fri, Apr 14, 2023 at 1:47 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Apr 14, 2023 at 01:01:36PM +0200, Patrick Rudolph wrote:
>
> > +     data->supply = devm_regulator_get_optional(dev, "vdd");
> > +     if (IS_ERR(data->supply)) {
> > +             ret = PTR_ERR(data->supply);
>
> Unless the device can work without power it should be using a normal
> regulator_get().