linux-kernel - Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59e0bd39-c510-4340-8781-feac1b6b4604@sirena.org.uk>
Date:   Fri, 14 Apr 2023 13:06:08 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Patrick Rudolph <patrick.rudolph@...ements.com>
Cc:     Peter Rosin <peda@...ntia.se>, Liam Girdwood <lgirdwood@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 3/3] i2c: muxes: pca954x: Add regulator support

On Fri, Apr 14, 2023 at 02:01:09PM +0200, Patrick Rudolph wrote:

> It was using the normal regulator_get() in the last revision, but
> Sergey requested to make it optional.
> Please advise me what to do here? Who is right?

As I said regulator_get_optional() is strictly for the case where the
supply may be physically absent and shouldn not be used in any other
situation.  Using the wrong variant will break error handling.

> 
> Regards,
> Patrick
> 
> On Fri, Apr 14, 2023 at 1:47 PM Mark Brown <broonie@...nel.org> wrote:

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)