linux-kernel - RE: [PATCH v2 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8P193MB2335F1954BC345575A2C8829CA999@AS8P193MB2335.EURP193.PROD.OUTLOOK.COM>
Date:   Fri, 14 Apr 2023 13:48:45 +0000
From:   Robbie King <robbiek@...ghtlabs.com>
To:     "lihuisong (C)" <lihuisong@...wei.com>,
        Sudeep Holla <sudeep.holla@....com>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "wanghuiqiang@...wei.com" <wanghuiqiang@...wei.com>,
        "zhangzekun11@...wei.com" <zhangzekun11@...wei.com>,
        "wangxiongfeng2@...wei.com" <wangxiongfeng2@...wei.com>,
        "tanxiaofei@...wei.com" <tanxiaofei@...wei.com>,
        "guohanjun@...wei.com" <guohanjun@...wei.com>,
        "xiexiuqi@...wei.com" <xiexiuqi@...wei.com>,
        "wangkefeng.wang@...wei.com" <wangkefeng.wang@...wei.com>,
        "huangdaode@...wei.com" <huangdaode@...wei.com>
Subject: RE: [PATCH v2 0/2] mailbox: pcc: Support platform notification for
 type4 and shared interrupt

Sorry for the delay.  I ran my simple stress test against the patch set and
saw no issues.  For the record it is by no means a thorough regression, but it
has illuminated issues in the past.

The test itself uses a "heartbeat" module in the SCP firmware that generates
notifications at a programmable interval.  The stress test is simply generating
these heartbeats (SCP to AP notifications) while also generating protocol version
queries (AP to SCP).  The notifications are sequence numbered to verify none are
lost, however SCP to AP notification support does not support SCP generating
notifications faster than the AP can process them, so the heartbeat rate must be
reasonably slow (on the order of 10s of millliseconds).

-----Original Message-----
From: lihuisong (C) <lihuisong@...wei.com> 
Sent: Thursday, April 13, 2023 9:05 PM
To: Robbie King <robbiek@...ghtlabs.com>; Sudeep Holla <sudeep.holla@....com>
Cc: linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org; rafael@...nel.org; rafael.j.wysocki@...el.com; wanghuiqiang@...wei.com; zhangzekun11@...wei.com; wangxiongfeng2@...wei.com; tanxiaofei@...wei.com; guohanjun@...wei.com; xiexiuqi@...wei.com; wangkefeng.wang@...wei.com; huangdaode@...wei.com
Subject: Re: [PATCH v2 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt


在 2023/4/11 22:47, Robbie King 写道:
> Apologies, missed earlier emails.  Will make this a priority for the week.
Thanks. Looking forward to you reply.
>
> -----Original Message-----
> From: lihuisong (C) <lihuisong@...wei.com>
> Sent: Sunday, April 9, 2023 9:27 PM
> To: Sudeep Holla <sudeep.holla@....com>; Robbie King 
> <robbiek@...ghtlabs.com>
> Cc: linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org; 
> rafael@...nel.org; rafael.j.wysocki@...el.com; 
> wanghuiqiang@...wei.com; zhangzekun11@...wei.com; 
> wangxiongfeng2@...wei.com; tanxiaofei@...wei.com; 
> guohanjun@...wei.com; xiexiuqi@...wei.com; wangkefeng.wang@...wei.com; 
> huangdaode@...wei.com
> Subject: Re: [PATCH v2 0/2] mailbox: pcc: Support platform 
> notification for type4 and shared interrupt
>
>
> 在 2023/3/27 20:31, lihuisong (C) 写道:
>> 在 2023/3/27 19:33, Sudeep Holla 写道:
>>> On Tue, Mar 14, 2023 at 07:11:33PM +0800, Huisong Li wrote:
>>>> PCC supports processing platform notification for slave subspaces 
>>>> and shared interrupt for multiple subspaces.
>>>>
>>> Other than a super minor nit in the patch 1/2, this looks good to me.
>>> It would be good if we can get tested-by from Robbie King 
>>> <robbiek@...ghtlabs.com>
>>>
>>> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
>> Thanks for your review.😁
>>
>> @Robbie King, can you give us some feedback?
>> Looking forward to you reply.
>>
>>
> @Robbie King, kindly ping.