linux-kernel - Re: [PATCH V5 2/5] cachefiles: extract ondemand info field from cachefiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2023 14:51:31 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jia Zhu <zhujia.zj@...edance.com>
Cc:     dhowells@...hat.com, linux-cachefs@...hat.com,
        linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        jefflexu@...ux.alibaba.com, hsiangkao@...ux.alibaba.com,
        yinxin.x@...edance.com
Subject: Re: [PATCH V5 2/5] cachefiles: extract ondemand info field from cachefiles_object

Jia Zhu <zhujia.zj@...edance.com> wrote:

>  #define CACHEFILES_OBJECT_STATE_FUNCS(_state, _STATE)	\
>  static inline bool								\
>  cachefiles_ondemand_object_is_##_state(const struct cachefiles_object *object) \
>  {												\
> -	return object->state == CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
> +	return object->ondemand->state == CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
>  }												\
>  												\
>  static inline void								\
>  cachefiles_ondemand_set_object_##_state(struct cachefiles_object *object) \
>  {												\
> -	object->state = CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
> +	object->ondemand->state = CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
>  }

I wonder if those need barriers - smp_load_acquire() and smp_store_release().

David