linux-kernel - Re: [RFC 2/4] buffer: add alloc_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505f1aac-8348-56c2-b925-6a905af9be24@samsung.com>
Date:   Fri, 14 Apr 2023 17:01:47 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <brauner@...nel.org>, <viro@...iv.linux.org.uk>,
        <akpm@...ux-foundation.org>, <linux-fsdevel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <mcgrof@...nel.org>,
        <gost.dev@...sung.com>, <hare@...e.de>
Subject: Re: [RFC 2/4] buffer: add alloc_folio_buffers() helper

On 2023-04-14 15:06, Matthew Wilcox wrote:
> On Fri, Apr 14, 2023 at 01:08:19PM +0200, Pankaj Raghav wrote:
>> Folio version of alloc_page_buffers() helper. This is required to convert
>> create_page_buffers() to create_folio_buffers() later in the series.
>>
>> It removes one call to compound_head() compared to alloc_page_buffers().
> 
> I would convert alloc_page_buffers() to folio_alloc_buffers() and
> add
> 
> static struct buffer_head *alloc_page_buffers(struct page *page,
> 		unsigned long size, bool retry)
> {
> 	return folio_alloc_buffers(page_folio(page), size, retry);
> }
> 
> in buffer_head.h
> 
> (there are only five callers, so this feels like a better tradeoff
> than creating a new function)
> 
That is a good idea and follows the usual pattern for folio conversion. I will
send a new version soon with your other comments as well.

--
Pankaj